[llvm-commits] [llvm] r73971 - in /llvm/trunk: include/llvm/System/Atomic.h include/llvm/Type.h lib/System/Atomic.cpp lib/VMCore/Mangler.cpp

[Owen Anderson]

Author: resistor
Date: Tue Jun 23 13:01:04 2009
New Revision: 73971

URL: http://llvm.org/viewvc/llvm-project?rev=73971&view=rev
Log:
Label the existing atomic functions as 32-bit specific, and add a 64-bit one that will be useful in
the near future.

Modified:
    llvm/trunk/include/llvm/System/Atomic.h
    llvm/trunk/include/llvm/Type.h
    llvm/trunk/lib/System/Atomic.cpp
    llvm/trunk/lib/VMCore/Mangler.cpp

Modified: llvm/trunk/include/llvm/System/Atomic.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/System/Atomic.h?rev=73971&r1=73970&r2=73971&view=diff

==============================================================================
--- llvm/trunk/include/llvm/System/Atomic.h (original)
+++ llvm/trunk/include/llvm/System/Atomic.h Tue Jun 23 13:01:04 2009
@@ -20,13 +20,14 @@
   namespace sys {
     void MemoryFence();
 
-    typedef uint32_t cas_flag;
-    cas_flag CompareAndSwap(volatile cas_flag* ptr,
-                            cas_flag new_value,
-                            cas_flag old_value);
-    cas_flag AtomicIncrement(volatile cas_flag* ptr);
-    cas_flag AtomicDecrement(volatile cas_flag* ptr);
-    cas_flag AtomicAdd(volatile cas_flag* ptr, cas_flag val);
+    uint32_t CompareAndSwap32(volatile uint32_t* ptr,
+                            uint32_t new_value,
+                            uint32_t old_value);
+    uint32_t AtomicIncrement32(volatile uint32_t* ptr);
+    uint32_t AtomicDecrement32(volatile uint32_t* ptr);
+    uint32_t AtomicAdd32(volatile uint32_t* ptr, uint32_t val);
+    
+    uint64_t AtomicAdd64(volatile uint64_t* ptr, uint64_t val);
   }
 }
 

Modified: llvm/trunk/include/llvm/Type.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Type.h?rev=73971&r1=73970&r2=73971&view=diff

==============================================================================
--- llvm/trunk/include/llvm/Type.h (original)
+++ llvm/trunk/include/llvm/Type.h Tue Jun 23 13:01:04 2009
@@ -103,7 +103,7 @@
   /// has no AbstractTypeUsers, the type is deleted.  This is only sensical for
   /// derived types.
   ///
-  mutable sys::cas_flag RefCount;
+  mutable uint32_t RefCount;
 
   const Type *getForwardedTypeInternal() const;
 
@@ -338,7 +338,7 @@
 
   void addRef() const {
     assert(isAbstract() && "Cannot add a reference to a non-abstract type!");
-    sys::AtomicIncrement(&RefCount);
+    sys::AtomicIncrement32(&RefCount);
   }
 
   void dropRef() const {
@@ -347,8 +347,8 @@
 
     // If this is the last PATypeHolder using this object, and there are no
     // PATypeHandles using it, the type is dead, delete it now.
-    sys::cas_flag OldCount = sys::AtomicDecrement(&RefCount);
-    if (OldCount == 0 && AbstractTypeUsers.empty())
+    uint32_t Count = sys::AtomicDecrement32(&RefCount);
+    if (Count == 0 && AbstractTypeUsers.empty())
       this->destroy();
   }
   

Modified: llvm/trunk/lib/System/Atomic.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/System/Atomic.cpp?rev=73971&r1=73970&r2=73971&view=diff

==============================================================================
--- llvm/trunk/lib/System/Atomic.cpp (original)
+++ llvm/trunk/lib/System/Atomic.cpp Tue Jun 23 13:01:04 2009
@@ -35,11 +35,11 @@
 #endif
 }
 
-sys::cas_flag sys::CompareAndSwap(volatile sys::cas_flag* ptr,
-                                  sys::cas_flag new_value,
-                                  sys::cas_flag old_value) {
+uint32_t sys::CompareAndSwap32(volatile uint32_t* ptr,
+                               uint32_t new_value,
+                               uint32_t old_value) {
 #if LLVM_MULTITHREADED==0
-  sys::cas_flag result = *ptr;
+  uint32_t result = *ptr;
   if (result == old_value)
     *ptr = new_value;
   return result;
@@ -52,7 +52,7 @@
 #endif
 }
 
-sys::cas_flag sys::AtomicIncrement(volatile sys::cas_flag* ptr) {
+uint32_t sys::AtomicIncrement32(volatile uint32_t* ptr) {
 #if LLVM_MULTITHREADED==0
   ++(*ptr);
   return *ptr;
@@ -65,7 +65,7 @@
 #endif
 }
 
-sys::cas_flag sys::AtomicDecrement(volatile sys::cas_flag* ptr) {
+uint32_t sys::AtomicDecrement32(volatile uint32_t* ptr) {
 #if LLVM_MULTITHREADED==0
   --(*ptr);
   return *ptr;
@@ -78,7 +78,7 @@
 #endif
 }
 
-sys::cas_flag sys::AtomicAdd(volatile sys::cas_flag* ptr, sys::cas_flag val) {
+uint32_t sys::AtomicAdd32(volatile uint32_t* ptr, uint32_t val) {
 #if LLVM_MULTITHREADED==0
   *ptr += val;
   return *ptr;
@@ -91,4 +91,16 @@
 #endif
 }
 
+uint64_t sys::AtomicAdd64(volatile uint64_t* ptr, uint64_t val) {
+#if LLVM_MULTITHREADED==0
+  *ptr += val;
+  return *ptr;
+#elif defined(__GNUC__)
+  return __sync_add_and_fetch(ptr, val);
+#elif defined(_MSC_VER)
+  return InterlockedAdd64(ptr, val);
+#else
+#  error No atomic add implementation for your platform!
+#endif
+}
 

Modified: llvm/trunk/lib/VMCore/Mangler.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/VMCore/Mangler.cpp?rev=73971&r1=73970&r2=73971&view=diff

==============================================================================
--- llvm/trunk/lib/VMCore/Mangler.cpp (original)
+++ llvm/trunk/lib/VMCore/Mangler.cpp Tue Jun 23 13:01:04 2009
@@ -168,7 +168,7 @@
     static uint32_t GlobalID = 0;
     
     unsigned OldID = GlobalID;
-    sys::AtomicIncrement(&GlobalID);
+    sys::AtomicIncrement32(&GlobalID);
     
     Name = "__unnamed_" + utostr(TypeUniqueID) + "_" + utostr(OldID);
   } else {