[llvm-commits] [llvm] r73887 - /llvm/trunk/lib/Target/ARM/ARMISelDAGToDAG.cpp

Anton Korobeynikov anton at korobeynikov.info
Mon Jun 22 14:39:19 PDT 2009


Hi, Bob

> Fix llvm-gcc build for armv6t2 and later architectures.  The hasV6T2Ops
> predicate does not check if Thumb mode is enabled, and when in ARM mode
> there are still some checks for constant-pool use that need to run.
What's the reason for this?

1. movt is available both in thumb and arm modes, there is no need to
check for thumb here.
2. ARM's compiler writing guide explicitly suggests not using constant
pool and materialize constants using pair of movw / movt.

-- 
With best regards, Anton Korobeynikov
Faculty of Mathematics and Mechanics, Saint Petersburg State University




More information about the llvm-commits mailing list