[llvm-commits] [PATCH] Remove GNU particuliers from NewNightlyTest.pl , more system portable.

[Tanya Lattner]

On Jun 19, 2009, at 10:27 AM, Bob Wilson wrote:

> I've committed the patch.  It worked fine on my tester, but one thing
> I noticed is that the file names submitted to the database before this
> patch had an extra slash in the paths, e.g., "Release//lib/
> libLLVMCore.a".  Now that extra slash is gone.  The nightly tester
> website will think they are different files -- it's not very smart --
> so the changes in file size will not be reported between yesterday and
> today.
>

Actually it is pretty important. I'm pretty sure this will break past  
results. So look at the graphs.. you will only see so far back. I know  
its true with the new nightly tester database since we have a table  
with filenames.

-Tanya

> On Jun 18, 2009, at 11:43 AM, Bob Wilson wrote:
>
>> Nice cleanup.  Thanks, Benjamin.  I'm going to try it out with my
>> nightly tester.  If everything goes well, I'll commit your patch
>> tomorrow.
>>
>> On Jun 18, 2009, at 4:31 AM, Benjamin Kramer wrote:
>>
>>> Sorry, but seeing this ugly perl code almost made my cry (not your
>>> fault though). So I decided to port it to File::Find which is part
>>> of perl's standard library.
>>>
>>> This gives us some advantages:
>>> 1. portability: File::Find works even on windows ;)
>>> 2. performance: the new code is >100 times faster on my machine. The
>>> slowdown is probably caused by backtracking in the old regex
>>> 3. cleanup: there were lots of duplicated code
>>>
>>>
>>> <nightlyfind.patch>
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20090619/b3b531fe/attachment.html>