[llvm-commits] [llvm] r73431 - in /llvm/trunk: include/llvm/ include/llvm/Analysis/ lib/Analysis/ lib/Transforms/Instrumentation/ lib/Transforms/Scalar/ lib/VMCore/ test/Feature/ test/Transforms/InstCombine/

[Chris Lattner]

On Jun 15, 2009, at 3:12 PM, Dan Gohman wrote:

> Author: djg
> Date: Mon Jun 15 17:12:54 2009
> New Revision: 73431
>
> URL: http://llvm.org/viewvc/llvm-project?rev=73431&view=rev
> Log:
> Support vector casts in more places, fixing a variety of assertion
> failures.
>
> To support this, add some utility functions to Type to help support
> vector/scalar-independent code. Change ConstantInt::get and
> ConstantFP::get to support vector types, and add an overload to
> ConstantInt::get that uses a static IntegerType type, for
> convenience.

Hi Dan,

Why should ConstantInt/FP::get allow a vector operand?  It seems very  
strange to me to allow this.

In general, please split up logically distinct changes into different  
pieces, it would be nice to have the core IR changes separately from  
the SCEV changes,

-Chris