[llvm-commits] [llvm] r73038 - in /llvm/trunk: include/llvm/Support/OutputBuffer.h lib/CodeGen/ELF.h lib/CodeGen/ELFCodeEmitter.cpp lib/CodeGen/ELFCodeEmitter.h lib/CodeGen/ELFWriter.cpp lib/CodeGen/ELFWriter.h

[Frits van Bommel]

Bruno Cardoso Lopes wrote:
> ==============================================================================
> --- llvm/trunk/lib/CodeGen/ELF.h (original)
> +++ llvm/trunk/lib/CodeGen/ELF.h Sun Jun  7 16:22:38 2009
> @@ -134,6 +165,15 @@
>      /// up for emission to the file.
>      std::vector<unsigned char> SectionData;
>  
> +    /// Relocations - The relocations that we have encountered so far in this 
> +    /// section that we will need to convert to MachORelocation entries when
> +    /// the file is written.
> +    std::vector<MachineRelocation> Relocations;

Paste-o in the comment? (This file is for ELF, not MachO, right?)

> ==============================================================================
> --- llvm/trunk/lib/CodeGen/ELFWriter.cpp (original)
> +++ llvm/trunk/lib/CodeGen/ELFWriter.cpp Sun Jun  7 16:22:38 2009
> @@ -284,7 +290,7 @@
>  
>    // Set the zero'th symbol to a null byte, as required.
>    StrTabOut.outbyte(0);
> -  SymbolTable[0].NameIdx = 0;
> +  //SymbolTable[0].NameIdx = 0;

Did you mean to comment that out? And if so, why comment rather than delete?