[llvm-commits] [llvm] r72894 - in /llvm/trunk: include/llvm/Attributes.h include/llvm/Target/TargetOptions.h lib/AsmParser/LLLexer.cpp lib/AsmParser/LLParser.cpp lib/AsmParser/LLToken.h lib/Target/PowerPC/PPCRegisterInfo.cpp lib/Target/TargetMach

[Devang Patel]

Hi Duncan,

On Fri, Jun 5, 2009 at 1:42 AM, Duncan Sands<baldrick at free.fr> wrote:
> Hi Devang,
>
>> Add new function attribute - noredzone.
>
> maybe there should be function notes as well as function
> attributes: the difference is that function attributes
> can be applied to a call as well as a function, while
> function notes would not apply to calls, only to functions.
> "noredzone" is an example of something that makes no sense
> on a callsite, so would be better as a function note.

After much discussion, we decided to not introduce function "notes"
and continue to use function attribute. I separated out parameter
attributes and return attributes from function attributes. The
function notes existed for very brief time in svn :). IMO it makes
sense to update verifier to catch meaning less attributes on callsite,
if you feel strongly.

>
> Ciao,
>
> Duncan.
>
> PS: The patch looks fine to me.

Thanks!
-
Devang