[llvm-commits] [llvm] r72811 - in /llvm/trunk: include/llvm/Support/StandardPasses.h tools/llvm-ld/Optimize.cpp tools/lto/LTOCodeGenerator.cpp

[Chris Lattner]

On Jun 3, 2009, at 2:51 PM, Daniel Dunbar wrote:

> Author: ddunbar
> Date: Wed Jun  3 16:51:32 2009
> New Revision: 72811
>
> URL: http://llvm.org/viewvc/llvm-project?rev=72811&view=rev
> Log:
> Change LTO to run the global opt pass twice.
> - This matches llvm-ld.
>
> It took a bit of archeology to figure out what the right thing to do  
> was
> (whether this was intentionally added or intentionally removed). My  
> final
> conclusion is that Chris added this intentionally here:
>  http://llvm.org/viewvc/llvm-project?view=rev&revision=16913
> but the changes weren't propogated to llvm-ld until here:
>  http://llvm.org/viewvc/llvm-project?view=rev&revision=34058
> which was after lto.cpp had been cloned off (of llvm-ld), here:
>  http://llvm.org/viewvc/llvm-project?view=rev&revision=29494
>
>> From the commit message, it looks like the motivation for running  
>> global opt
> again is because we ran it prior to inlining. Based on that I  
> updated the
> comment and also only run the pass if we actually ran the inliner.

Sounds fine to me! GlobalOpt is quite cheap.

-Chris