[llvm-commits] patch: Lower glibc's x86 bswap_32() inline asm

[Chris Lattner]

On May 27, 2009, at 11:54 AM, Chris Lattner wrote:

>
> On May 27, 2009, at 11:52 AM, Dale Johannesen wrote:
>
>>> If llvm-gcc is telling GLIBC that the target is < i486, it would  
>>> seem
>>> to be a better approach would be to configure llvm-gcc to not do
>>> that.
>>>
>>> Offhand I don't know the specific configure options to recommend,  
>>> but
>>> it seems to be some combination of --with-arch= and --with-target=
>>> possibly along with --with-tune=generic. If someone can figure out
>>> specific values to recommend, we can put them in README.LLVM.
>>
>> There are values recommended there, but only for Darwin.  I think the
>> with-arch and with-tune values should be generally applicable,  
>> though.
>
> I think it is best to recommend -march=pentium4 at the very least, to
> get SSE2 support.

However, I don't see why this means we shouldn't take the patch  
though, if it is ok.  Can someone review the patch?

-Chris