[llvm-commits] [PATCH] Detect GCC atomic builtins in configure

[Eric Christopher]

On May 18, 2009, at 2:44 PM, Owen Anderson wrote:


> And here's Take 3, in which I incorporate feedback from Eric, and  
> figure out the difference between AC_SUBST and AC_DEFINE!

Quite a better, couple of questions/comments:

a)  If you're doing this then why the configure flag? Shouldn't  
something just fail to link ultimately if this is wrong?

b) I'm pretty sure that you don't need the [] around the values - at  
least not for AC_SUBST and AC_DEFINE.

c) The bits above for enable_thread should probably look like what I  
sent last night.

d) This should also probably be right under that in the configure.ac  
file. Confusing otherwise :)

-eric