[llvm-commits] [llvm] r71407 - in /llvm/trunk: docs/LangRef.html include/llvm/Constants.h include/llvm/MDNode.h lib/AsmParser/LLParser.cpp lib/AsmParser/LLParser.h lib/Bitcode/Reader/BitcodeReader.cpp lib/Bitcode/Writer/BitcodeWriter.cpp lib/Bitcode/Writer/ValueEnumerator.cpp lib/VMCore/AsmWriter.cpp lib/VMCore/Constants.cpp test/Feature/embeddedmetadata.ll unittests/VMCore/MetadataTest.cpp

[Nick Lewycky]

Bill and Frits, thanks for the fix! I picked a very very bad time to be 
AFK for a while. Sorry!

Nick

Bill Wendling wrote:
> Applied. Thanks!
> 
> -bw
> 
> On May 10, 2009, at 4:21 PM, Frits van Bommel wrote:
> 
>> Bill Wendling wrote:
>>> Did you forget a file in this commit? :-)
>>> /Volumes/Sandbox/Buildbot/llvm/full-llvm/build/llvmCore.roots/  
>>> llvmCore~obj/src/lib/VMCore/Verifier.cpp: In function 'bool   
>>> isMetadata(llvm::Value*)':
>>> /Volumes/Sandbox/Buildbot/llvm/full-llvm/build/llvmCore.roots/  
>>> llvmCore~obj/src/lib/VMCore/Verifier.cpp:354: error: 'MDNode' was  
>>> not  declared in this scope
>>> /Volumes/Sandbox/Buildbot/llvm/full-llvm/build/llvmCore.roots/  
>>> llvmCore~obj/src/lib/VMCore/Verifier.cpp:354: error: no matching   
>>> function for call to 'isa(llvm::Value*&)'
>> There are some missing #includes. See attached patch.
>> (LLVM will build without #including Type.h from MDNode.h, but only  
>> by accident: a file with MDNode.h as its first #include fails)
>> <mdnode-includes.patch>_______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>