[llvm-commits] [llvm] r71242 - /llvm/trunk/lib/CodeGen/CodePlacementOpt.cpp

[Evan Cheng]

Author: evancheng
Date: Fri May  8 14:01:44 2009
New Revision: 71242

URL: http://llvm.org/viewvc/llvm-project?rev=71242&view=rev
Log:
Don't align loop header unless the loop back edge is below the header.

Modified:
    llvm/trunk/lib/CodeGen/CodePlacementOpt.cpp

Modified: llvm/trunk/lib/CodeGen/CodePlacementOpt.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/CodePlacementOpt.cpp?rev=71242&r1=71241&r2=71242&view=diff

==============================================================================
--- llvm/trunk/lib/CodeGen/CodePlacementOpt.cpp (original)
+++ llvm/trunk/lib/CodeGen/CodePlacementOpt.cpp Fri May  8 14:01:44 2009
@@ -249,6 +249,20 @@
   return Changed;
 }
 
+/// HeaderShouldBeAligned - Return true if the specified loop header block
+/// should be aligned. For now, we will not align it if all the predcessors
+/// (i.e. loop back edges) are laid out above the header. FIXME: Do not
+/// align small loops.
+static bool HeaderShouldBeAligned(MachineBasicBlock *MBB) {
+  for (MachineBasicBlock::pred_iterator PI = MBB->pred_begin(),
+         PE = MBB->pred_end(); PI != PE; ++PI) {
+    MachineBasicBlock *PredMBB = *PI;
+    if (PredMBB->getNumber() > MBB->getNumber())
+      return true;
+  }
+  return false;
+}
+
 /// AlignLoops - Align loop headers to target preferred alignments.
 ///
 bool CodePlacementOpt::AlignLoops(MachineFunction &MF) {
@@ -267,9 +281,11 @@
   for (unsigned i = 0, e = LoopHeaders.size(); i != e; ++i) {
     MachineBasicBlock *HeaderMBB = LoopHeaders[i];
     MachineBasicBlock *PredMBB = prior(MachineFunction::iterator(HeaderMBB));
-    if (MLI->getLoopFor(HeaderMBB) != MLI->getLoopFor(PredMBB)) {
+    if (MLI->getLoopFor(HeaderMBB) == MLI->getLoopFor(PredMBB))
       // If previously BB is in the same loop, don't align this BB. We want
       // to prevent adding noop's inside a loop.
+      continue;
+    if (HeaderShouldBeAligned(HeaderMBB)) {
       HeaderMBB->setAlignment(Align);
       Changed = true;
       ++NumHeaderAligned;