[llvm-commits] [llvm] r71077 - in /llvm/trunk: lib/Transforms/IPO/FunctionAttrs.cpp test/Transforms/FunctionAttrs/2009-05-06-Malloc.ll

[Chris Lattner]

On May 6, 2009, at 8:02 PM, Nick Lewycky wrote:

> Duncan Sands wrote:
>> Author: baldrick
>> Date: Wed May  6 03:42:00 2009
>> New Revision: 71077
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=71077&view=rev
>> Log:
>> Fix PR3754: don't mark functions that wrap MallocInst with
>> the readnone.  Since MallocInst is scheduled for deletion
>> it doesn't seem worth doing anything more subtle, such as
>> having mayWriteToMemory return true for MallocInst.
>
> I don't like this fix at all. What's wrong with just making
> mayWriteToMemory return true on MallocInst?

I agree, that seems like the obvious fix...?

-Chris