[llvm-commits] [llvm] r69978 - /llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp

Bob Wilson bob.wilson at apple.com
Fri Apr 24 13:53:42 PDT 2009


Upon further investigation....  The comment _did_ match the code, but  
I believe the code to be incorrect.  There's not much point in  
reverting a change to a comment, but I'll be sure to put things back  
in a state where comment == code once I finish sorting this out.

On Apr 24, 2009, at 10:05 AM, Bob Wilson wrote:

> Author: bwilson
> Date: Fri Apr 24 12:05:01 2009
> New Revision: 69978
>
> URL: http://llvm.org/viewvc/llvm-project?rev=69978&view=rev
> Log:
> Adjust a comment to reflect what the code does.  Splitting a 64-bit  
> argument
> between registers and the stack may be required with the APCS ABI,  
> but it
> isn't tied to using a particular version of the ARM architecture.
>
> Modified:
>    llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp
>
> Modified: llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp?rev=69978&r1=69977&r2=69978&view=diff
>
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> ======================================================================
> --- llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp (original)
> +++ llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp Fri Apr 24  
> 12:05:01 2009
> @@ -1103,7 +1103,7 @@
>
>         VA = ArgLocs[++i]; // skip ahead to next loc
>         if (VA.isMemLoc()) {
> -          // must be APCS and older than V5T to split like this
> +          // must be APCS to split like this
>           unsigned ArgSize = VA.getLocVT().getSizeInBits()/8;
>           int FI = MFI->CreateFixedObject(ArgSize,  
> VA.getLocMemOffset());
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits




More information about the llvm-commits mailing list