[llvm-commits] [llvm] r69946 - in /llvm/trunk: docs/LangRef.html lib/Transforms/Scalar/InstructionCombining.cpp lib/VMCore/Type.cpp

Duncan Sands baldrick at free.fr
Fri Apr 24 07:29:19 PDT 2009


Hi Sanjiv,

> -only integers of 32 or 64 bits are allowed (also non-constants). 32-bit values
> +only integers of 16, 32 or 64 bits are allowed (also non-constants).16-bit 

Missing space between the . and 16.  Also, there is a trailing space on this line,
and doubled spaces in the next line:
> +values will be sign extended to 32-bits if required, and  32-bit values

>      %eptr = getelementptr [12 x i8]* %aptr, i64 0, i32 1
> +    <i>; yields i16*:iptr</i>
> +    %iptr = getelementptr [10 x i16]* @arr, i16 0, i16 0

I think it's confusing to have both the index and the array
involve i16's: people might think that there's some kind of
connection between have an i16 pointer and an i16 index.

Ciao,

Duncan.



More information about the llvm-commits mailing list