[llvm-commits] [llvm-gcc-4.2] r68848 - /llvm-gcc-4.2/trunk/gcc/llvm-debug.cpp

[Dan Gohman]

On Apr 13, 2009, at 1:05 PM, Devang Patel wrote:

>
> On Apr 13, 2009, at 12:59 PM, Dan Gohman wrote:
>
>>
>> On Apr 10, 2009, at 5:17 PM, Devang Patel wrote:
>>
>>> Author: dpatel
>>> Date: Fri Apr 10 19:17:54 2009
>>> New Revision: 68848
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=68848&view=rev
>>> Log:
>>> If linkage name is not available then use function display name as
>>> linkage name.
>>
>> Hi Devang,
>>
>> What does this fix? Why is a bogus linkage name better than no
>> linkage name?
>
>
> In C, linkage name is same as name.

And in pretty much everything else, it can be different.

>
> This info is used during FastISel to decide whether we are at the
> beginning of inlined subroutine or not.
>
>       std::string SPName;
>       Subprogram.getLinkageName(SPName);
>       if (!SPName.empty()
>           && strcmp(SPName.c_str(), MF.getFunction()-
>> getNameStart())) {

Could this use

    Subprogram.getGV() == MF.getFunction()

instead?

Dan