[llvm-commits] [PATCH] Fix simple crashing bug in MachineInstr::getNumExplicitOperands

[Misha Brukman]

On Wed, Apr 8, 2009 at 3:30 PM, Jakob Stoklund Olesen <stoklund at 2pi.dk>wrote:

> On 08/04/2009, at 21.04, Dan Gohman wrote:
>
>>
>> I agree that the code in MachineInstr::getNumExplicitOperands
>> looks wrong. According to ARMInstrThumb.td, tPOP_RET has variable_ops
>> though, and IIRC the way things currently work is that these
>> extra operands get added after the implicit operands, so I think
>> this patch isn't the right fix.
>>
>
> In that case, maybe this was the intention?
> Tested with "make check".


Note that "make check" does not automatically rebuild the tools used in
testing; you have to "make tools-only" first to make sure you're running the
code you modified, rather than the binaries from a previous build.

I sent a patch to llvm-commits to solicit feedback as to whether it's safe
-- see the archives if you want to try it out.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20090408/93f54caf/attachment.html>