[llvm-commits] [llvm] r68465 - in /llvm/trunk: docs/BitCodeFormat.html include/llvm/Bitcode/BitCodes.h include/llvm/Bitcode/BitstreamReader.h include/llvm/Bitcode/BitstreamWriter.h

Chris Lattner clattner at apple.com
Tue Apr 7 09:31:04 PDT 2009


On Apr 7, 2009, at 12:47 AM, Duncan Sands wrote:
>> +    Blob  = 5   // 8-bit aligned array of 8-bit characters.
>
> in the docs it says 32-bit aligned, but here it says 8-bit...

Nice catch, fixed!

>> +        // Align end to 32-bits.
>> +        while (Out.size() & 3)
>> +          Out.push_back(0);
>
> Can you use FlushToWord() here instead?

Unfortunately no, by directly pushing bytes onto the output stream,  
we're subverting the bit-wise mechanism that flushtoword uses.

-Chris



More information about the llvm-commits mailing list