[llvm-commits] [llvm] r67879 - /llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuild.h

[Dan Gohman]

On Mar 28, 2009, at 3:55 AM, Duncan Sands wrote:

> Hi Dan,
>
>> Initialize LiveOutInfo's APInt members to zero, as APInt's
>> default constructor produces an uninitialized APInt.
>> This fixes PR3896.
>
> is this the correct fix?  If LiveOutInfo was default
> constructed, doesn't this mean it doesn't contain
> anything useful.  If so, why is it being examined?
> Also, will the code that uses it come to the right
> conclusions given this initialization?

Hi Duncan,

LiveOutRegInfo is a std::vector<LiveOutInfo> which is populated
with resize.  The expectation is that elements contain
"nothing known" values unless more information is added to them.

Dan