[llvm-commits] [llvm] r67943 - in /llvm/trunk: lib/CodeGen/SelectionDAG/TargetLowering.cpp test/CodeGen/X86/tailcall-void.ll

Duncan Sands baldrick at free.fr
Sat Mar 28 05:43:35 PDT 2009


Hi Arnold, thanks for doing this.

> +  // Ignore MERGE_VALUES. Will have at least one operand.
> +  if (node.getOpcode() == ISD::MERGE_VALUES)
> +    return IgnoreHarmlessInstructions(node.getOperand(0));

The order of operands in a MERGE_VALUES node has no significance:
permuting them does not change the meaning of the node.  Thus only
checking the first operand has to be wrong, even if it works in
practice...

Ciao,

Duncan.



More information about the llvm-commits mailing list