[llvm-commits] [llvm] r67469 - /llvm/trunk/Makefile.rules

[Julien Lerouge]

On Fri, Mar 27, 2009 at 08:01:23AM -0700, Mike Stump wrote:
> On Mar 26, 2009, at 11:18 PM, Julien Lerouge wrote:
> > Here is the output on ppc, it seems to be the same thing on intel.
> >
> > g++ -I/Users/buildbot/buildbot/llvm-src/include -I/Users/buildbot/ 
> > buildbot/llvm-src/lib/Transforms/Hello -I/Users/buildbot/buildbot/ 
> > llvm/llvm-build/include -I/Users/buildbot/buildbot/llvm/llvm-build/ 
> > lib/Transforms/Hello  -D_DEBUG  -D_GNU_SOURCE -D__STDC_LIMIT_MACROS - 
> > D__STDC_CONSTANT_MACROS -O3  -fno-exceptions -fno-common  - 
> > Woverloaded-virtual  -mmacosx-version-min=10.4  -pedantic -Wall -W - 
> > Wwrite-strings -Wno-long-long -Wunused -Wno-unused-parameter  - 
> > fstrict-aliasing -Wstrict-aliasing -O3  -module -L/Users/buildbot/ 
> > buildbot/llvm/llvm-build/Release/lib -L/Users/buildbot/buildbot/llvm/ 
> > llvm-build/Release/lib  -Wl,-flat_namespace -Wl,-undefined - 
> > Wl,suppress -Wl,-dylib
> 
> Ick, this is wrong, try just -dynamiclib instead.
> 
> >>>> -  SharedLinkOptions=-Wl,-flat_namespace -Wl,-undefined - 
> >>>> Wl,suppress -dylib \
> >>>> +  SharedLinkOptions=-Wl,-flat_namespace -Wl,-undefined - 
> >>>> Wl,suppress -Wl,-dylib \
> >>>>                     -mmacosx-version-min=$(DARWIN_VERSION)
> 
> Yup, right there.
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

I tried: 

===================================================================
--- Makefile.rules      (revision 67820)
+++ Makefile.rules      (working copy)
@@ -435,7 +435,7 @@
   # Get "4" out of 10.4 for later pieces in the makefile.
   DARWIN_MAJVERS := $(shell echo $(DARWIN_VERSION)| sed -E 's/10.([0-9]).*/\1/')

-  SharedLinkOptions=-Wl,-flat_namespace -Wl,-undefined -Wl,suppress -Wl,-dylib \
+  SharedLinkOptions=-Wl,-flat_namespace -Wl,-undefined -Wl,suppress -dynamiclib \
                     -mmacosx-version-min=$(DARWIN_VERSION)
   TargetCommonOpts += -mmacosx-version-min=$(DARWIN_VERSION)
 else
  SharedLinkOptions=-Wl,-flat_namespace -Wl,-undefined -Wl,suppress -dynamiclib \
                    -mmacosx-version-min=$(DARWIN_VERSION)
 
and it worked.

Can we commit this change ?

Thanks,
Julien

-- 
Julien Lerouge
PGP Key Id: 0xB1964A62
PGP Fingerprint: 392D 4BAD DB8B CE7F 4E5F FA3C 62DB 4AA7 B196 4A62
PGP Public Key from: keyserver.pgp.com