[llvm-commits] [llvm] r67002 - in /llvm/trunk: lib/Target/X86/AsmPrinter/X86ATTAsmPrinter.cpp test/CodeGen/X86/rip-rel-address.ll

[Dan Gohman]

Author: djg
Date: Fri Mar 13 21:33:41 2009
New Revision: 67002

URL: http://llvm.org/viewvc/llvm-project?rev=67002&view=rev
Log:
Use %rip-relative addressing on x86-64 whenever practical, as
it has a smaller encoding than absolute addressing.

Added:
    llvm/trunk/test/CodeGen/X86/rip-rel-address.ll
Modified:
    llvm/trunk/lib/Target/X86/AsmPrinter/X86ATTAsmPrinter.cpp

Modified: llvm/trunk/lib/Target/X86/AsmPrinter/X86ATTAsmPrinter.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/AsmPrinter/X86ATTAsmPrinter.cpp?rev=67002&r1=67001&r2=67002&view=diff

==============================================================================
--- llvm/trunk/lib/Target/X86/AsmPrinter/X86ATTAsmPrinter.cpp (original)
+++ llvm/trunk/lib/Target/X86/AsmPrinter/X86ATTAsmPrinter.cpp Fri Mar 13 21:33:41 2009
@@ -471,14 +471,15 @@
           O << "@GOT";
         else
           O << "@GOTOFF";
-      } else if (Subtarget->isPICStyleRIPRel() && !NotRIPRel &&
-                 TM.getRelocationModel() != Reloc::Static) {
-        if (Subtarget->GVRequiresExtraLoad(GV, TM, false))
-          O << "@GOTPCREL";
-
-        if (needCloseParen) {
-          needCloseParen = false;
-          O << ')';
+      } else if (Subtarget->isPICStyleRIPRel() && !NotRIPRel) {
+        if (TM.getRelocationModel() != Reloc::Static) {
+          if (Subtarget->GVRequiresExtraLoad(GV, TM, false))
+            O << "@GOTPCREL";
+
+          if (needCloseParen) {
+            needCloseParen = false;
+            O << ')';
+          }
         }
 
         // Use rip when possible to reduce code size, except when
@@ -692,7 +693,7 @@
     switch (ExtraCode[0]) {
     default: return true;  // Unknown modifier.
     case 'c': // Don't print "$" before a global var name or constant.
-      printOperand(MI, OpNo, "mem");
+      printOperand(MI, OpNo, "mem", /*NotRIPRel=*/true);
       return false;
     case 'b': // Print QImode register
     case 'h': // Print QImode high register

Added: llvm/trunk/test/CodeGen/X86/rip-rel-address.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/rip-rel-address.ll?rev=67002&view=auto

==============================================================================
--- llvm/trunk/test/CodeGen/X86/rip-rel-address.ll (added)
+++ llvm/trunk/test/CodeGen/X86/rip-rel-address.ll Fri Mar 13 21:33:41 2009
@@ -0,0 +1,7 @@
+; RUN: llvm-as < %s | llc -march=x86-64 -relocation-model=static | grep {a(%rip)}
+
+ at a = internal global double 3.4
+define double @foo() nounwind {
+  %a = load double* @a
+  ret double %a
+}