[llvm-commits] [llvm] r66339 - in /llvm/trunk: docs/ include/llvm-c/ include/llvm/ lib/Analysis/ lib/AsmParser/ lib/Bitcode/Reader/ lib/Bitcode/Writer/ lib/CodeGen/ lib/CodeGen/AsmPrinter/ lib/CodeGen/SelectionDAG/ lib/ExecutionEngine/JIT/ lib/Linker/ lib/Target/ lib/Target/ARM/ lib/Target/ARM/AsmPrinter/ lib/Target/Alpha/AsmPrinter/ lib/Target/CellSPU/AsmPrinter/ lib/Target/CppBackend/ lib/Target/IA64/ lib/Target/Mips/ lib/Target/PowerPC/AsmPrinter/ lib/Target/Sparc/AsmPrinter/ lib/Target/X86/ lib/Target/X86/AsmPrinte...

[Duncan Sands]

Hi Nick,

> Duncan, I can't build MultiSource/Applications/hbd due to this patch:
> 
> llvm-ld: LinkModules.cpp:510: bool GetLinkageResult(llvm::GlobalValue*, 
> const llvm::GlobalValue*, llvm::GlobalValue::LinkageTypes&, bool&, 
> std::string*): Assertion `(Dest->hasExternalLinkage() || 
> Dest->hasDLLImportLinkage() || Dest->hasDLLExportLinkage() || 
> Dest->hasExternalWeakLinkage()) && (Src->hasExternalLinkage() || 
> Src->hasDLLImportLinkage() || Src->hasDLLExportLinkage() || 
> Src->hasExternalWeakLinkage()) && "Unexpected linkage type!"' failed.

this doesn't make any sense to me because hasExternalWeakLinkage
and friends return "true" if the linkage is either the traditional
one or the odr one.

> ...
> Please take a look at lib/Linker/LinkModules.cpp GetLinkageResult and 
> add support for your linkage types in there.

I already did, see above.  Also, I checked that the entire testsuite
builds and runs ok with these changes, so I don't understand why you
have this problem.  Can you please rummage around in the debugger and
try to get more info.

Thanks a lot,

Duncan.