[llvm-commits] [test-suite] r65872 - /test-suite/trunk/External/SPEC/Makefile.spec

[Dan Gohman]

Author: djg
Date: Mon Mar  2 15:30:41 2009
New Revision: 65872

URL: http://llvm.org/viewvc/llvm-project?rev=65872&view=rev
Log:
Use '$(if ...)' instead of 'ifdef'  because the former allows variables
expanded in the condition to be "recursively expanded variables"
rather than just "immediately expanded variables". See the make manual
and the comments in the commit for details.

Modified:
    test-suite/trunk/External/SPEC/Makefile.spec

Modified: test-suite/trunk/External/SPEC/Makefile.spec
URL: http://llvm.org/viewvc/llvm-project/test-suite/trunk/External/SPEC/Makefile.spec?rev=65872&r1=65871&r2=65872&view=diff

==============================================================================
--- test-suite/trunk/External/SPEC/Makefile.spec (original)
+++ test-suite/trunk/External/SPEC/Makefile.spec Mon Mar  2 15:30:41 2009
@@ -94,13 +94,15 @@
 # output with the program's output.
 BUGPOINT_OPTIONS += -append-exit-code
 
-# If a tolerance is set, pass it off to bugpoint
-ifdef FP_TOLERANCE
-BUGPOINT_OPTIONS += -rel-tolerance $(FP_TOLERANCE)
-endif
-ifdef FP_ABSTOLERANCE
-BUGPOINT_OPTIONS += -abs-tolerance $(FP_ABSTOLERANCE)
-endif
+# If a tolerance is set, pass it off to bugpoint.
+#
+# Note: this uses '$(if ...)' instead of ifeq so that FP_TOLERANCE and
+# FP_ABSTOLERANCE can be "recursively expanded". The purpose of this is
+# to allow the indivdiaul benchmark Makefiles to set FP_TOLERANCE
+# after including this file, which they may need to do if they wish to
+# have it depend on the value of RUN_TYPE.
+BUGPOINT_OPTIONS += $(if $(FP_TOLERANCE),-rel-tolerance $(FP_TOLERANCE),)
+BUGPOINT_OPTIONS += $(if $(FP_ABSTOLERANCE),-abs-tolerance $(FP_ABSTOLERANCE),)
 
 
 # Give bugpoint information about LDFLAGS to pass down to the actual link stage