[llvm-commits] [llvm] r65356 - in /llvm/branches/Apple/Dib:, lib/CodeGen/AsmPrinter/DwarfWriter.cpp, lib/Transforms/Utils/BasicBlockUtils.cpp, lib/Transforms/Utils/SimplifyCFG.cpp, test/Transforms/SimplifyCFG/dbginfo.ll

[Devang Patel]

On Feb 24, 2009, at 12:28 AM, Sheng Zhou wrote:

> Hi Patel,
>
>> Author: dpatel
>> Date: Mon Feb 23 18:05:16 2009
>> New Revision: 65353
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=65353&view=rev
>> Log:
>> While folding unconditional return move DbgRegionEndInst into the  
>> predecessor, instead of removing it. This fixes following tests  
>> from llvmgcc42 testsuite.
>>
>> gcc.c-torture/execute/20000605-3.c
>> gcc.c-torture/execute/20020619-1.c
>> gcc.c-torture/execute/20030920-1.c
>> gcc.c-torture/execute/loop-ivopts-1.c
>>
>>
>> Modified:
>>    llvm/trunk/lib/Transforms/Utils/BasicBlockUtils.cpp
>>    llvm/trunk/lib/Transforms/Utils/SimplifyCFG.cpp
>>    llvm/trunk/test/Transforms/SimplifyCFG/dbginfo.ll
>>
> Attached is a .ll case (before.ll). And with your change, I got
> "after.ll" after pass -simplifycfg which folded unconditional return  
> and
> moved DbgRegionEndInst into pred. The question is in after.ll now  
> there
> are two "ret" instructions in two basic blocks:

I do not understand. As far as I can tell, this patch has no impact on  
your test case.
-
Devang