[llvm-commits] [llvm] r64812 - /llvm/trunk/tools/gold/gold-plugin.cpp

[Nick Lewycky]

Rafael Espindola wrote:
> Author: rafael
> Date: Tue Feb 17 15:08:21 2009
> New Revision: 64812
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=64812&view=rev
> Log:
> tools like nm and ar only need register_claim_file and add_symbols. Don't abort
> if other hooks are missing.

:-)

> Modified:
>     llvm/trunk/tools/gold/gold-plugin.cpp
> 
> Modified: llvm/trunk/tools/gold/gold-plugin.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/gold/gold-plugin.cpp?rev=64812&r1=64811&r2=64812&view=diff
> 
> ==============================================================================
> --- llvm/trunk/tools/gold/gold-plugin.cpp (original)
> +++ llvm/trunk/tools/gold/gold-plugin.cpp Tue Feb 17 15:08:21 2009
> @@ -142,11 +142,16 @@
>      }
>    }
>  
> -  if (!registeredClaimFile || !registeredAllSymbolsRead || !registeredCleanup ||
> -      !add_symbols || !get_symbols || !add_input_file) {
> -    (*message)(LDPL_ERROR, "Not all hooks registered for LLVMgold.");
> -    return LDPS_ERR;
> -  }
> +  if (!registeredClaimFile)
> +    {
> +      (*message)(LDPL_ERROR, "register_claim_file not passed to LLVMgold.");
> +      return LDPS_ERR;
> +    }
> +  if (!add_symbols)
> +    {
> +      (*message)(LDPL_ERROR, "add_symbols not passed to LLVMgold.");
> +      return LDPS_ERR;
> +    }

Please follow the LLVM style for gold-plugin.cc. Notably, we put the 
open brace on the same line at the if statement.

Nick

>  
>    return LDPS_OK;
>  }
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>