[llvm-commits] [llvm-gcc-4.2] r64584 - /llvm-gcc-4.2/trunk/gcc/cgraphunit.c

[Bill Wendling]

Done.

-bw

On Feb 17, 2009, at 10:34 AM, Dale Johannesen wrote:

>
> On Feb 15, 2009, at 3:25 AMPST, Bill Wendling wrote:
>>
>> @@ -1331,13 +1331,8 @@
>> #endif
>> 	  gcc_assert (node->global.inlined_to || !DECL_SAVED_TREE (decl)
>>                      /* LLVM LOCAL begin - extern inline */
>> -#ifdef ENABLE_LLVM
>> 		      || IS_EXTERN_INLINE (decl));
>> -#else
>> -		      || DECL_EXTERNAL (decl));
>> -#endif
>>                      /* LLVM LOCAL end - extern inline */
>
> This is the wrong idea.  IS_EXTERN_INLINE is defined as
>
> #ifdef ENABLE_LLVM
> #define IS_EXTERN_INLINE(f) (DECL_EXTERNAL(f) && \
>           !lookup_attribute("always_inline", DECL_ATTRIBUTES(f)))
> #else
> #define IS_EXTERN_INLINE(f) (DECL_EXTERNAL(f))
> #endif
>
> so it reduces to DECL_EXTERNAL in the non-LLVM build.  There should  
> be no #ifdef's at any of the call sites, please remove them.
>