[llvm-commits] r64000 breaks PIC16

[Chris Lattner]

On Feb 17, 2009, at 10:14 AM, Alireza.Moshtaghi at microchip.com wrote:

> Hi Chris,
> I was busy with some other stuff and just now got to try this...
> The flag SDNPOutFlag is set for subfw but the sinker does not look at
> it. I have to also set the flag SDNPSideEffect for it to work  
> correctly.
> Now the question is SDNPOutFlag not a reason for keeping the  
> instruction
> in its place? Or there may be need to for some corrections in the
> sinker?

Hi Ali,

This needs to be a property on the machine instruction, not on the dag  
node.  The X86 backend uses:

let Defs = [EFLAGS] in {

}

around instructions that define the flags for example.  You can also  
use the "Imp" helper to set this on specific instructions.

-Chris