[llvm-commits] [llvm] r63999 - in /llvm/trunk: lib/CodeGen/LLVMTargetMachine.cpp test/CodeGen/ARM/lsr-code-insertion.ll test/CodeGen/X86/2006-05-11-InstrSched.ll

Evan Cheng evan.cheng at apple.com
Sat Feb 7 17:21:27 PST 2009


I've confirmed it's miscompiling X86ISelLowering.cpp  
LowerToTLSGeneralDynamicModel32. I'm digging into it now.

Evan

On Feb 7, 2009, at 1:13 PM, Evan Cheng wrote:

> Can you revert it for now? Thanks.
>
> Evan
>
> On Feb 7, 2009, at 1:47 AM, Bill Wendling <isanbard at gmail.com> wrote:
>
>> Evan,
>>
>> This is breaking the self-hosting build:
>>
>> http://blamebot.apple.com:8020/builders/full-llvm-OSX/builds/200/steps/shell/logs/stdio
>>
>> Could you investigate this please?
>>
>> -bw
>>
>> On Feb 6, 2009, at 5:57 PM, Evan Cheng wrote:
>>
>>> Author: evancheng
>>> Date: Fri Feb  6 19:57:46 2009
>>> New Revision: 63999
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=63999&view=rev
>>> Log:
>>> Enable machine sinking pass in non-fast mode.
>>>
>>> Modified:
>>>  llvm/trunk/lib/CodeGen/LLVMTargetMachine.cpp
>>>  llvm/trunk/test/CodeGen/ARM/lsr-code-insertion.ll
>>>  llvm/trunk/test/CodeGen/X86/2006-05-11-InstrSched.ll
>>>
>>> Modified: llvm/trunk/lib/CodeGen/LLVMTargetMachine.cpp
>>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/LLVMTargetMachine.cpp?rev=63999&r1=63998&r2=63999&view=diff
>>>
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> ===
>>> ===================================================================
>>> --- llvm/trunk/lib/CodeGen/LLVMTargetMachine.cpp (original)
>>> +++ llvm/trunk/lib/CodeGen/LLVMTargetMachine.cpp Fri Feb  6 19:57:46
>>> 2009
>>> @@ -38,11 +38,6 @@
>>> static cl::opt<bool> PrintGCInfo("print-gc", cl::Hidden,
>>>   cl::desc("Dump garbage collector data"));
>>>
>>> -// Hidden options to help debugging
>>> -static cl::opt<bool>
>>> -EnableSinking("enable-sinking", cl::init(false), cl::Hidden,
>>> -              cl::desc("Perform sinking on machine code"));
>>> -
>>> // When this works it will be on by default.
>>> static cl::opt<bool>
>>> DisablePostRAScheduler("disable-post-RA-scheduler",
>>> @@ -183,11 +178,10 @@
>>> if (PrintMachineCode)
>>>   PM.add(createMachineFunctionPrinterPass(cerr));
>>>
>>> -  if (!Fast)
>>> +  if (!Fast) {
>>>   PM.add(createMachineLICMPass());
>>> -
>>> -  if (EnableSinking)
>>>   PM.add(createMachineSinkingPass());
>>> +  }
>>>
>>> // Run pre-ra passes.
>>> if (addPreRegAlloc(PM, Fast) && PrintMachineCode)
>>>
>>> Modified: llvm/trunk/test/CodeGen/ARM/lsr-code-insertion.ll
>>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/ARM/lsr-code-insertion.ll?rev=63999&r1=63998&r2=63999&view=diff
>>>
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> ===
>>> ===================================================================
>>> --- llvm/trunk/test/CodeGen/ARM/lsr-code-insertion.ll (original)
>>> +++ llvm/trunk/test/CodeGen/ARM/lsr-code-insertion.ll Fri Feb  6
>>> 19:57:46 2009
>>> @@ -1,4 +1,4 @@
>>> -; RUN: llvm-as < %s | llc -stats |& grep {39.*Number of machine
>>> instrs printed}
>>> +; RUN: llvm-as < %s | llc -stats |& grep {40.*Number of machine
>>> instrs printed}
>>> ; RUN: llvm-as < %s | llc -stats |& grep {.*Number of re-
>>> materialization}
>>> ; This test really wants to check that the resultant "cond_true"
>>> block only
>>> ; has a single store in it, and that cond_true55 only has code to
>>> materialize
>>>
>>> Modified: llvm/trunk/test/CodeGen/X86/2006-05-11-InstrSched.ll
>>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/2006-05-11-InstrSched.ll?rev=63999&r1=63998&r2=63999&view=diff
>>>
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> ===
>>> ===================================================================
>>> --- llvm/trunk/test/CodeGen/X86/2006-05-11-InstrSched.ll (original)
>>> +++ llvm/trunk/test/CodeGen/X86/2006-05-11-InstrSched.ll Fri Feb  6
>>> 19:57:46 2009
>>> @@ -1,5 +1,5 @@
>>> ; RUN: llvm-as < %s | llc -march=x86 -mattr=+sse2 -stats -realign-
>>> stack=0 |&\
>>> -; RUN:     grep {asm-printer} | grep 32
>>> +; RUN:     grep {asm-printer} | grep 31
>>>
>>> target datalayout = "e-p:32:32"
>>> define void @foo(i32* %mc, i32* %bp, i32* %ms, i32* %xmb, i32* %mpp,
>>> i32* %tpmm, i32* %ip, i32* %tpim, i32* %dpp, i32* %tpdm, i32* %bpi,
>>> i32 %M) nounwind {
>>>
>>>
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits




More information about the llvm-commits mailing list