[llvm-commits] [llvm] r63992 - in /llvm/trunk: include/llvm/CodeGen/ lib/CodeGen/SelectionDAG/ lib/Target/ARM/ lib/Target/Alpha/ lib/Target/CellSPU/ lib/Target/Mips/ lib/Target/PIC16/ lib/Target/PowerPC/ lib/Target/Sparc/ lib/Target/X86/ lib/Target/XCore/

Chris Lattner clattner at apple.com
Fri Feb 6 22:20:03 PST 2009


On Feb 6, 2009, at 4:55 PM, Dale Johannesen wrote:

> Author: johannes
> Date: Fri Feb  6 18:55:49 2009
> New Revision: 63992
>
> URL: http://llvm.org/viewvc/llvm-project?rev=63992&view=rev
> Log:
> Get rid of the last non-DebugLoc versions of getNode!
>
> Many targets build placeholder nodes for special operands, e.g.
> GlobalBaseReg on X86 and PPC for the PIC base.  There's no
> sensible way to associate debug info with these.  I've left
> them built with getNode calls with explicit DebugLoc::getUnknownLoc  
> operands.
> I'm not too happy about this but don't see a good improvement;
> I considered adding a getPseudoOperand or something, but it
> seems to me that'll just make it harder to read.

I think that using unknownloc is a pretty decent solution for this  
case.  Many thanks for all the effort to get us fully moved over Dale,  
I really appreciate it!

-Chris



More information about the llvm-commits mailing list