[llvm-commits] FoldingSet of string with NULLs inside

Chris Lattner clattner at apple.com
Fri Feb 6 08:23:33 PST 2009


On Feb 5, 2009, at 11:35 PM, Nick Lewycky wrote:

> I noticed that FoldingSet has two copies of the same code for  
> AddString. I took a stab at refactoring them into one shared  
> function that just takes two char*'s. This has the added benefit of  
> allowing strings that have NULLs in the middle.
>
> I'm not familiar with this code so I thought I'd send it out for  
> review first.

Looks great to me, plz apply.

-Chris



More information about the llvm-commits mailing list