[llvm-commits] [llvm] r63900 - in /llvm/trunk: include/llvm/Analysis/AliasAnalysis.h lib/Analysis/AliasAnalysis.cpp lib/Analysis/AliasDebugger.cpp lib/Analysis/BasicAliasAnalysis.cpp lib/Analysis/IPA/GlobalsModRef.cpp

Duncan Sands baldrick at free.fr
Fri Feb 6 00:10:00 PST 2009


Hi Owen,

> -  if (Function *F = CS.getCalledFunction())
> -    MRB = getModRefBehavior(F, CS, Info);
> +  ModRefBehavior MRB = getModRefBehavior(CS.getCalledFunction(), Info);

what if CS.getCalledFunction() is null?

> +  if (isAtomicRMW(CS.getCalledFunction()))
> +    // CAS and related intrinsics only access their arguments.

How about modifying the definition of IntrWriteArgMem so it doesn't
imply nocapture anymore (existing users of IntrWriteArgMem can have
their arguments marked nocapture explicitly) and mark these atomics
IntrWriteArgMem?

Ciao,

Duncan.



More information about the llvm-commits mailing list