[llvm-commits] [llvm] r63539 - /llvm/trunk/win32/config.h

Gabor Greif ggreif at gmail.com
Tue Feb 3 13:59:17 PST 2009


No, PACKAGE_STRING looks awesome, but I have my doubts about
PACKAGE_VERSION (the line above your change).

Cheers,

   Gabor

On 3 fev, 22:48, steve naroff <snar... at apple.com> wrote:
> On Feb 3, 2009, at 4:41 PM, Gabor Greif wrote:
>
>
>
> > On 3 fev, 01:41, Bill Wendling <isanb... at gmail.com> wrote:
> >> On Mon, Feb 2, 2009 at 12:39 PM, Gabor Greif <ggr... at gmail.com>  
> >> wrote:
> >>> On 2 Feb., 20:22, Steve Naroff <snar... at apple.com> wrote:
> >>>> Author: snaroff
> >>>> Date: Mon Feb  2 13:22:02 2009
> >>>> New Revision: 63539
>
> >>>> URL:http://llvm.org/viewvc/llvm-project?rev=63539&view=rev
> >>>> Log:
> >>>> Update hand-crafted VC++ build.
> >>>> - Add PACKAGE_STRING definition to Windows config.h.
>
> >>>> Modified:
> >>>>     llvm/trunk/win32/config.h
>
> >>>> Modified: llvm/trunk/win32/config.h
> >>>> URL:http://llvm.org/viewvc/llvm-project/llvm/trunk/win32/config.h?rev=635
> >>>> ...
>
> >>>> =
> >>>> =
> >>>> =
> >>>> =
> >>>> =
> >>>> =
> >>>> =
> >>>> =
> >>>> =
> >>>> =
> >>>> =================================================================  
> >>>> ===
> >>>> --- llvm/trunk/win32/config.h (original)
> >>>> +++ llvm/trunk/win32/config.h Mon Feb  2 13:22:02 2009
> >>>> @@ -3,6 +3,7 @@
>
> >>>>  #define PACKAGE_NAME "LLVM (win32 vc8.0)"
> >>>>  #define PACKAGE_VERSION 2.4
>
> >>> Bill, this ^^^^^^ does not seem right.
>
> >> Bill? :-)
>
> > Ehrm, sorry Bill, that should be Steve... :-)
>
> Gabor,
>
> I assume you are talking about  the #define for PACKAGE_STRING?
>
> I added it just to make the Windows work. If the #define is incorrect,  
> please let me know why (and I will be happy to fix it).
>
> Thanks,
>
> snaroff
>
> > Cheers,
>
> >    Gabor
>
> >> -bw
> >> _______________________________________________
> >> llvm-commits mailing list
> >> llvm-comm... at cs.uiuc.eduhttp://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
> _______________________________________________
> llvm-commits mailing list
> llvm-comm... at cs.uiuc.eduhttp://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits




More information about the llvm-commits mailing list