[llvm-commits] [llvm] r62045 - /llvm/trunk/lib/Transforms/Scalar/InstructionCombining.cpp

[Chris Lattner]

On Jan 15, 2009, at 2:01 PM, Nicolas Geoffray wrote:
>> IMO, mid-level optimizations that we want to run from "opt" or "llvm-
>> ld" should never call addRequired<TargetData>/
>> getAnalysis<TargetData>.  Instead, they should call
>> getAnalysisToUpdate<TargetData>().  This method returns a pointer if
>> TargetData is around, or returns null if not.  That would mean that
>> passes (like instcombine) that want to use targetdata would (for
>> xforms that need it) check to see if the pointer is non-null, then  
>> try
>> to do the xform in question.
>>
>> Does this seem reasonable?
>>
>
> Yes it does. VMKit outputs a portable .bc from Java or C#, and it's
> unfortunate opt is changing it to a non-portable .bc file.

Hi Nicolas,

Can you please summarize this discussion in a bugzilla report?  It  
would be nice to track this.  Thanks,

-Chris