[llvm-commits] [llvm] r62533 - in /llvm/trunk: lib/CodeGen/SelectionDAG/DAGCombiner.cpp lib/CodeGen/SelectionDAG/SelectionDAG.cpp test/CodeGen/X86/pr3018.ll

[Duncan Sands]

Hi Dan,

> Fix SelectionDAG::ReplaceAllUsesWith to behave correctly when
> uses are added to the From node while it is processing From's
> use list, because of automatic local CSE. The fix is to avoid
> visiting any new uses.
> 
> Fix a few places in the DAGCombiner that assumed that after
> a RAUW call, the From node has no users and may be deleted.

this might cause problems for legalize types - not sure.  There's
a bunch of logic there to deal with similar problems, but I'm not
sure it is valid now that there is this new mechanism.  I will do
some thinking/testing.

Also, can you please document this behavior somewhere.

Thanks,

Duncan.