[llvm-commits] [llvm] r62415 - /llvm/trunk/lib/Target/X86/X86ISelLowering.cpp

[Bill Wendling]

Er. This wasn't supposed to be committed without the testcase. The log  
should say something like:

"Extend the UINT_TO_FP lowering to account for i32 to values other  
than f32."

-bw

On Jan 16, 2009, at 11:40 PM, Bill Wendling wrote:

> Author: void
> Date: Sat Jan 17 01:40:19 2009
> New Revision: 62415
>
> URL: http://llvm.org/viewvc/llvm-project?rev=62415&view=rev
> Log:
> Extend thi
>
>
> Modified:
>    llvm/trunk/lib/Target/X86/X86ISelLowering.cpp
>
> Modified: llvm/trunk/lib/Target/X86/X86ISelLowering.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86ISelLowering.cpp?rev=62415&r1=62414&r2=62415&view=diff
>
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> ======================================================================
> --- llvm/trunk/lib/Target/X86/X86ISelLowering.cpp (original)
> +++ llvm/trunk/lib/Target/X86/X86ISelLowering.cpp Sat Jan 17  
> 01:40:19 2009
> @@ -121,11 +121,7 @@
>       setOperationAction(ISD::UINT_TO_FP   , MVT::i64  , Custom);
>
>       // We have faster algorithm for ui32->single only.
> -#if 0
>       setOperationAction(ISD::UINT_TO_FP   , MVT::i32  , Custom);
> -#else
> -      setOperationAction(ISD::UINT_TO_FP   , MVT::i32  , Expand);
> -#endif
>     } else
>       setOperationAction(ISD::UINT_TO_FP   , MVT::i32  , Promote);
>   }
> @@ -4874,8 +4870,17 @@
>   SDValue Sub = DAG.getNode(ISD::FSUB, MVT::f64, Or, Bias);
>
>   // Handle final rounding.
> -  return DAG.getNode(ISD::FP_ROUND, MVT::f32, Sub,
> -                     DAG.getIntPtrConstant(0));
> +  MVT DestVT = Op.getValueType();
> +
> +  if (DestVT.bitsLT(MVT::f64)) {
> +    return DAG.getNode(ISD::FP_ROUND, DestVT, Sub,
> +                       DAG.getIntPtrConstant(0));
> +  } else if (DestVT.bitsGT(MVT::f64)) {
> +    return DAG.getNode(ISD::FP_EXTEND, DestVT, Sub);
> +  }
> +
> +  // Handle final rounding.
> +  return Sub;
> }
>
> SDValue X86TargetLowering::LowerUINT_TO_FP(SDValue Op, SelectionDAG  
> &DAG) {
> @@ -4885,13 +4890,9 @@
>     // We only handle SSE2 f64 target here; caller can handle the  
> rest.
>     if (Op.getValueType() != MVT::f64 || !X86ScalarSSEf64)
>       return SDValue();
> -
> +
>     return LowerUINT_TO_FP_i64(Op, DAG);
>   } else if (SrcVT == MVT::i32) {
> -    // We only handle SSE2 f32 target here; caller can handle the  
> rest.
> -    if (Op.getValueType() != MVT::f32 || !X86ScalarSSEf32)
> -      return SDValue();
> -
>     return LowerUINT_TO_FP_i32(Op, DAG);
>   }
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits