[llvm-commits] [llvm] r62144 - in /llvm/trunk: lib/CodeGen/SimpleRegisterCoalescing.cpp test/CodeGen/X86/2009-01-12-CoalescerBug.ll
Nick Lewycky
nicholas at mxc.ca
Mon Jan 12 21:00:54 PST 2009
Evan Cheng wrote:
> Author: evancheng
> Date: Mon Jan 12 21:57:45 2009
> New Revision: 62144
>
> URL: http://llvm.org/viewvc/llvm-project?rev=62144&view=rev
> Log:
> FIX llvm-gcc bootstrap on x86_64 linux. If a virtual register is copied to a physical register, it's not necessarily defined by a copy. We have to watch out it doesn't clobber any sub-register that might be live during its live interval. If the live interval crosses a basic block, then it's not safe to check with the less conservative check (by scanning uses and defs) because it's possible a sub-register might be live out of the block.
Did you forget a file?
llvm[2]: Compiling SimpleRegisterCoalescing.cpp for Debug build
/home/nicholas/llvm-commit/include/llvm/CodeGen/LiveIntervalAnalysis.h:
In member function 'bool
llvm::SimpleRegisterCoalescing::JoinIntervals(llvm::LiveInterval&,
llvm::LiveInterval&, bool&)':
/home/nicholas/llvm-commit/include/llvm/CodeGen/LiveIntervalAnalysis.h:467:
error: 'bool llvm::LiveIntervals::intervalIsInOneMBB(const
llvm::LiveInterval&) const' is private
SimpleRegisterCoalescing.cpp:1747: error: within this context
make[2]: ***
[/home/nicholas/llvm-commit/lib/CodeGen/Debug/SimpleRegisterCoalescing.o]
Error 1
Nick
>
> Added:
> llvm/trunk/test/CodeGen/X86/2009-01-12-CoalescerBug.ll
> Modified:
> llvm/trunk/lib/CodeGen/SimpleRegisterCoalescing.cpp
>
> Modified: llvm/trunk/lib/CodeGen/SimpleRegisterCoalescing.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SimpleRegisterCoalescing.cpp?rev=62144&r1=62143&r2=62144&view=diff
>
> ==============================================================================
> --- llvm/trunk/lib/CodeGen/SimpleRegisterCoalescing.cpp (original)
> +++ llvm/trunk/lib/CodeGen/SimpleRegisterCoalescing.cpp Mon Jan 12 21:57:45 2009
> @@ -1731,7 +1731,20 @@
> // If it's coalescing a virtual register to a physical register, estimate
> // its live interval length. This is the *cost* of scanning an entire live
> // interval. If the cost is low, we'll do an exhaustive check instead.
> +
> + // If this is something like this:
> + // BB1:
> + // v1024 = op
> + // ...
> + // BB2:
> + // ...
> + // RAX = v1024
> + //
> + // That is, the live interval of v1024 crosses a bb. Then we can't rely on
> + // less conservative check. It's possible a sub-register is defined before
> + // v1024 (or live in) and live out of BB1.
> if (RHS.containsOneValue() &&
> + li_->intervalIsInOneMBB(RHS) &&
> li_->getApproximateInstructionCount(RHS) <= 10) {
> // Perform a more exhaustive check for some common cases.
> if (li_->conflictsWithPhysRegRef(RHS, LHS.reg, true, JoinedCopies))
>
> Added: llvm/trunk/test/CodeGen/X86/2009-01-12-CoalescerBug.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/2009-01-12-CoalescerBug.ll?rev=62144&view=auto
>
> ==============================================================================
> --- llvm/trunk/test/CodeGen/X86/2009-01-12-CoalescerBug.ll (added)
> +++ llvm/trunk/test/CodeGen/X86/2009-01-12-CoalescerBug.ll Mon Jan 12 21:57:45 2009
> @@ -0,0 +1,84 @@
> +; RUN: llvm-as < %s | llc -mtriple=x86_64-unknown-linux-gnu | grep movq | count 2
> +; PR3311
> +
> + %struct.CUMULATIVE_ARGS = type { i32, i32, i32, i32, i32, i32, i32, i32, i32, i32, i32, i32, i32, i32 }
> + %struct.VEC_basic_block_base = type { i32, i32, [1 x %struct.basic_block_def*] }
> + %struct.VEC_basic_block_gc = type { %struct.VEC_basic_block_base }
> + %struct.VEC_edge_base = type { i32, i32, [1 x %struct.edge_def*] }
> + %struct.VEC_edge_gc = type { %struct.VEC_edge_base }
> + %struct.VEC_rtx_base = type { i32, i32, [1 x %struct.rtx_def*] }
> + %struct.VEC_rtx_gc = type { %struct.VEC_rtx_base }
> + %struct.VEC_temp_slot_p_base = type { i32, i32, [1 x %struct.temp_slot*] }
> + %struct.VEC_temp_slot_p_gc = type { %struct.VEC_temp_slot_p_base }
> + %struct.VEC_tree_base = type { i32, i32, [1 x %struct.tree_node*] }
> + %struct.VEC_tree_gc = type { %struct.VEC_tree_base }
> + %struct._obstack_chunk = type { i8*, %struct._obstack_chunk*, [4 x i8] }
> + %struct.basic_block_def = type { %struct.tree_node*, %struct.VEC_edge_gc*, %struct.VEC_edge_gc*, i8*, %struct.loop*, [2 x %struct.et_node*], %struct.basic_block_def*, %struct.basic_block_def*, %struct.basic_block_il_dependent, %struct.tree_node*, %struct.edge_prediction*, i64, i32, i32, i32, i32 }
> + %struct.basic_block_il_dependent = type { %struct.rtl_bb_info* }
> + %struct.bitmap_element_def = type { %struct.bitmap_element_def*, %struct.bitmap_element_def*, i32, [2 x i64] }
> + %struct.bitmap_head_def = type { %struct.bitmap_element_def*, %struct.bitmap_element_def*, i32, %struct.bitmap_obstack* }
> + %struct.bitmap_obstack = type { %struct.bitmap_element_def*, %struct.bitmap_head_def*, %struct.obstack }
> + %struct.block_symbol = type { [3 x %struct.rtunion], %struct.object_block*, i64 }
> + %struct.c_arg_info = type { %struct.tree_node*, %struct.tree_node*, %struct.tree_node*, %struct.tree_node*, %struct.tree_node*, i8 }
> + %struct.c_language_function = type { %struct.stmt_tree_s }
> + %struct.c_switch = type opaque
> + %struct.control_flow_graph = type { %struct.basic_block_def*, %struct.basic_block_def*, %struct.VEC_basic_block_gc*, i32, i32, i32, %struct.VEC_basic_block_gc*, i32 }
> + %struct.edge_def = type { %struct.basic_block_def*, %struct.basic_block_def*, %struct.edge_def_insns, i8*, %struct.location_t*, i32, i32, i64, i32 }
> + %struct.edge_def_insns = type { %struct.rtx_def* }
> + %struct.edge_prediction = type opaque
> + %struct.eh_status = type opaque
> + %struct.emit_status = type { i32, i32, %struct.rtx_def*, %struct.rtx_def*, %struct.sequence_stack*, i32, %struct.location_t, i32, i8*, %struct.rtx_def** }
> + %struct.et_node = type opaque
> + %struct.expr_status = type { i32, i32, i32, %struct.rtx_def*, %struct.rtx_def*, %struct.rtx_def* }
> + %struct.function = type { %struct.eh_status*, %struct.expr_status*, %struct.emit_status*, %struct.varasm_status*, %struct.control_flow_graph*, %struct.tree_node*, %struct.function*, i32, i32, i32, i32, %struct.rtx_def*, %struct.CUMULATIVE_ARGS, %struct.rtx_def*, %struct.rtx_def*, %struct.initial_value_struct*, %struct.rtx_def*, %struct.rtx_def*, %struct.rtx_def*, %struct.rtx_def*, %struct.rtx_def*, %struct.rtx_def*, i8, i32, i64, %struct.tree_node*, %struct.tree_node*, %struct.rtx_def*, %struct.VEC_temp_slot_p_gc*, %struct.temp_slot*, %struct.var_refs_queue*, i32, i32, i32, i32, %struct.machine_function*, i32, i32, %struct.language_function*, %struct.htab*, %struct.rtx_def*, i32, i32, i32, %struct.location_t, %struct.VEC_tree_gc*, %struct.tree_node*, i8*, i8*, i8*, i8*, i8*, %struct.tree_node*, i8, i8, i8, i8, i8, i8 }
> + %struct.htab = type { i32 (i8*)*, i32 (i8*, i8*)*, void (i8*)*, i8**, i64, i64, i64, i32, i32, i8* (i64, i64)*, void (i8*)*, i8*, i8* (i8*, i64, i64)*, void (i8*, i8*)*, i32 }
> + %struct.initial_value_struct = type opaque
> + %struct.lang_decl = type { i8 }
> + %struct.language_function = type { %struct.c_language_function, %struct.tree_node*, %struct.tree_node*, %struct.c_switch*, %struct.c_arg_info*, i32, i32, i32, i32 }
> + %struct.location_t = type { i8*, i32 }
> + %struct.loop = type opaque
> + %struct.machine_function = type { %struct.stack_local_entry*, i8*, %struct.rtx_def*, i32, i32, [4 x i32], i32, i32, i32 }
> + %struct.object_block = type { %struct.section*, i32, i64, %struct.VEC_rtx_gc*, %struct.VEC_rtx_gc* }
> + %struct.obstack = type { i64, %struct._obstack_chunk*, i8*, i8*, i8*, i64, i32, %struct._obstack_chunk* (i8*, i64)*, void (i8*, %struct._obstack_chunk*)*, i8*, i8 }
> + %struct.omp_clause_subcode = type { i32 }
> + %struct.rtl_bb_info = type { %struct.rtx_def*, %struct.rtx_def*, %struct.bitmap_head_def*, %struct.bitmap_head_def*, %struct.rtx_def*, %struct.rtx_def*, i32 }
> + %struct.rtunion = type { i8* }
> + %struct.rtx_def = type { i16, i8, i8, %struct.u }
> + %struct.section = type { %struct.unnamed_section }
> + %struct.sequence_stack = type { %struct.rtx_def*, %struct.rtx_def*, %struct.sequence_stack* }
> + %struct.stack_local_entry = type opaque
> + %struct.stmt_tree_s = type { %struct.tree_node*, i32 }
> + %struct.temp_slot = type opaque
> + %struct.tree_common = type { %struct.tree_node*, %struct.tree_node*, %union.tree_ann_d*, i8, i8, i8, i8, i8 }
> + %struct.tree_decl_common = type { %struct.tree_decl_minimal, %struct.tree_node*, i8, i8, i8, i8, i8, i32, i32, %struct.tree_node*, %struct.tree_node*, %struct.tree_node*, %struct.tree_node*, i64, %struct.lang_decl* }
> + %struct.tree_decl_minimal = type { %struct.tree_common, %struct.location_t, i32, %struct.tree_node*, %struct.tree_node* }
> + %struct.tree_decl_non_common = type { %struct.tree_decl_with_vis, %struct.tree_node*, %struct.tree_node*, %struct.tree_node*, %struct.tree_node* }
> + %struct.tree_decl_with_rtl = type { %struct.tree_decl_common, %struct.rtx_def*, i32 }
> + %struct.tree_decl_with_vis = type { %struct.tree_decl_with_rtl, %struct.tree_node*, %struct.tree_node*, i8, i8, i8, i8 }
> + %struct.tree_function_decl = type { %struct.tree_decl_non_common, i32, i8, i8, i64, %struct.function* }
> + %struct.tree_node = type { %struct.tree_function_decl }
> + %struct.u = type { %struct.block_symbol }
> + %struct.unnamed_section = type { %struct.omp_clause_subcode, void (i8*)*, i8*, %struct.section* }
> + %struct.var_refs_queue = type { %struct.rtx_def*, i32, i32, %struct.var_refs_queue* }
> + %struct.varasm_status = type opaque
> + %union.tree_ann_d = type opaque
> + at .str1 = external constant [31 x i8] ; <[31 x i8]*> [#uses=1]
> + at integer_types = external global [11 x %struct.tree_node*] ; <[11 x %struct.tree_node*]*> [#uses=1]
> + at __FUNCTION__.31164 = external constant [23 x i8], align 16 ; <[23 x i8]*> [#uses=1]
> + at llvm.used = appending global [1 x i8*] [ i8* bitcast (i32 (i32, i32)* @c_common_type_for_size to i8*) ], section "llvm.metadata" ; <[1 x i8*]*> [#uses=0]
> +
> +define i32 @c_common_type_for_size(i32 %bits, i32 %unsignedp) nounwind {
> +entry:
> + %0 = load %struct.tree_node** getelementptr ([11 x %struct.tree_node*]* @integer_types, i32 0, i64 5), align 8 ; <%struct.tree_node*> [#uses=1]
> + br i1 false, label %bb16, label %bb
> +
> +bb: ; preds = %entry
> + tail call void @tree_class_check_failed(%struct.tree_node* %0, i32 2, i8* getelementptr ([31 x i8]* @.str1, i32 0, i64 0), i32 1785, i8* getelementptr ([23 x i8]* @__FUNCTION__.31164, i32 0, i32 0)) noreturn nounwind
> + unreachable
> +
> +bb16: ; preds = %entry
> + %tmp = add i32 %bits, %unsignedp ; <i32> [#uses=1]
> + ret i32 %tmp
> +}
> +
> +declare void @tree_class_check_failed(%struct.tree_node*, i32, i8*, i32, i8*) noreturn
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
More information about the llvm-commits
mailing list