[llvm-commits] [PATCH] Unit tests for StringMap

Talin viridia at gmail.com
Wed Jan 7 12:33:52 PST 2009


Here's StringMapTest, and some minor cleanup of DenseMapTest. Oh, and I
found a bug in StringMap during the process of writing the tests, the fix is
also included.
Some notes:

   - I could not get StringMapEntryInitializer to compile, so those tests
   are disabled. Even more puzzling is that I could not find any code that uses
   StringMapEntryInitializer (I was hoping to find an example as to how to do
   the explicit specialization.)
   - I was very surprised that the default implementation of
   StringMapEntryInitializer is empty (no action) instead of a generic
   assignment - it means that insert() basically doesn't work, as the value
   never gets copied to the StringMapEntry.

-- 
-- Talin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20090107/37983906/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: stringmap_unit.patch
Type: application/octet-stream
Size: 7048 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20090107/37983906/attachment.obj>


More information about the llvm-commits mailing list