[llvm-commits] [llvm] r61828 - in /llvm/trunk: lib/CodeGen/SelectionDAG/SelectionDAGBuild.cpp test/CodeGen/Generic/pr3288.ll

[Dan Gohman]

Author: djg
Date: Tue Jan  6 16:53:52 2009
New Revision: 61828

URL: http://llvm.org/viewvc/llvm-project?rev=61828&view=rev
Log:
Fix a bug in ComputeLinearIndex computation handling multi-level
aggregate types. Don't increment the current index after reaching
the end of a struct, as it will already be pointing at
one-past-the end. This fixes PR3288.

Added:
    llvm/trunk/test/CodeGen/Generic/pr3288.ll
Modified:
    llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuild.cpp

Modified: llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuild.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuild.cpp?rev=61828&r1=61827&r2=61828&view=diff

==============================================================================
--- llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuild.cpp (original)
+++ llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuild.cpp Tue Jan  6 16:53:52 2009
@@ -63,7 +63,7 @@
                  cl::init(0));
 
 /// ComputeLinearIndex - Given an LLVM IR aggregate type and a sequence
-/// insertvalue or extractvalue indices that identify a member, return
+/// of insertvalue or extractvalue indices that identify a member, return
 /// the linearized index of the start of the member.
 ///
 static unsigned ComputeLinearIndex(const TargetLowering &TLI, const Type *Ty,
@@ -84,6 +84,7 @@
         return ComputeLinearIndex(TLI, *EI, Indices+1, IndicesEnd, CurIndex);
       CurIndex = ComputeLinearIndex(TLI, *EI, 0, 0, CurIndex);
     }
+    return CurIndex;
   }
   // Given an array type, recursively traverse the elements.
   else if (const ArrayType *ATy = dyn_cast<ArrayType>(Ty)) {
@@ -93,6 +94,7 @@
         return ComputeLinearIndex(TLI, EltTy, Indices+1, IndicesEnd, CurIndex);
       CurIndex = ComputeLinearIndex(TLI, EltTy, 0, 0, CurIndex);
     }
+    return CurIndex;
   }
   // We haven't found the type we're looking for, so keep searching.
   return CurIndex + 1;

Added: llvm/trunk/test/CodeGen/Generic/pr3288.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/Generic/pr3288.ll?rev=61828&view=auto

==============================================================================
--- llvm/trunk/test/CodeGen/Generic/pr3288.ll (added)
+++ llvm/trunk/test/CodeGen/Generic/pr3288.ll Tue Jan  6 16:53:52 2009
@@ -0,0 +1,67 @@
+; RUN: llvm-as < %s | llc
+; PR3288
+
+define void @a() {
+  %i = insertvalue [2 x [2 x i32]] undef, [2 x i32] undef, 1
+  ret void
+}
+define void @b() {
+  %i = insertvalue {{i32,float},{i16,double}} undef, {i16,double} undef, 1
+  ret void
+}
+define void @c() {
+  %i = insertvalue [2 x [2 x i32]] zeroinitializer, [2 x i32] zeroinitializer, 1
+  ret void
+}
+define void @d() {
+  %i = insertvalue {{i32,float},{i16,double}} zeroinitializer, {i16,double} zeroinitializer, 1
+  ret void
+}
+define void @e() {
+  %i = insertvalue [2 x [2 x i32]] undef, [2 x i32] undef, 0
+  ret void
+}
+define void @f() {
+  %i = insertvalue {{i32,float},{i16,double}} undef, {i32,float} undef, 0
+  ret void
+}
+define void @g() {
+  %i = insertvalue [2 x [2 x i32]] zeroinitializer, [2 x i32] zeroinitializer, 0
+  ret void
+}
+define void @h() {
+  %i = insertvalue {{i32,float},{i16,double}} zeroinitializer, {i32,float} zeroinitializer, 0
+  ret void
+}
+define void @ax() {
+  %i = insertvalue [2 x [2 x i32]] undef, i32 undef, 1, 1
+  ret void
+}
+define void @bx() {
+  %i = insertvalue {{i32,float},{i16,double}} undef, double undef, 1, 1
+  ret void
+}
+define void @cx() {
+  %i = insertvalue [2 x [2 x i32]] zeroinitializer, i32 zeroinitializer, 1, 1
+  ret void
+}
+define void @dx() {
+  %i = insertvalue {{i32,float},{i16,double}} zeroinitializer, double zeroinitializer, 1, 1
+  ret void
+}
+define void @ex() {
+  %i = insertvalue [2 x [2 x i32]] undef, i32 undef, 0, 1
+  ret void
+}
+define void @fx() {
+  %i = insertvalue {{i32,float},{i16,double}} undef, float undef, 0, 1
+  ret void
+}
+define void @gx() {
+  %i = insertvalue [2 x [2 x i32]] zeroinitializer, i32 zeroinitializer, 0, 1
+  ret void
+}
+define void @hx() {
+  %i = insertvalue {{i32,float},{i16,double}} zeroinitializer, float zeroinitializer, 0, 1
+  ret void
+}