[llvm-commits] [llvm] r61239 - in /llvm/trunk: docs/LangRef.html include/llvm/Attributes.h lib/Analysis/BasicAliasAnalysis.cpp test/Analysis/BasicAA/nocapture.ll

Eric Christopher echristo at apple.com
Mon Dec 22 15:26:40 PST 2008


On Dec 22, 2008, at 1:09 PM, Eric Christopher wrote:

> I'm seeing failures on darwin due to this:
>
>  /// getParamAlignment - Return the alignment for the specified
> function
>   /// parameter.
>   unsigned getParamAlignment(unsigned Idx) const {
>     Attributes Align = getAttributes(Idx) & Attribute::Alignment;
>     if (Align == 0)
>       return 0;
>
>     return 1ull << ((Align >> 16) - 1);
>   }
>
> there's a warning (local to darwin -Wshorten64-to-32) here that we're
> truncating the return value from 64 to 32.

fwiw the obvious cast to unsigned works, but isn't preferable.

What happened to the changes in the patch you were testing?

-eric



More information about the llvm-commits mailing list