[llvm-commits] Patch: x86 multiply v2i64

Eli Friedman eli.friedman at gmail.com
Wed Dec 17 19:16:20 PST 2008


On Wed, Dec 17, 2008 at 6:37 PM, Mon Ping Wang <monping at apple.com> wrote:
> Hi,
>
> This is a patch to fix multiply of v2i64.  Today, on SSE4.1, we map a
> multiply of v2i64 to pmuldq which does two 32 bit multiples that generates
> two 64 bit results, which is incorrect.  This patch removes that

Did you forget to include a file in your patch?

> and instead
> lowers it to set of vector code that works for SSE2+.  Please let me know if
> you have any comments.

On x86-64, would we prefer to scalarize this?  Other than that, looks fine.

-Eli



More information about the llvm-commits mailing list