[llvm-commits] [PATCH] Debug info utilities and printer pass

Török Edwin edwintorok at gmail.com
Tue Dec 16 02:12:32 PST 2008

On 2008-12-16 00:09, Evan Cheng wrote:
> So you are setting DIDescriptor::GV to null? If so, please don't use  
> the same name for the parameter. It's confusing.

I changed the parameter to gv.

> I think it's better to write something like
> bool printed = DSI != 0;

Ok, changed.

>> Thanks for the comments, do you see any other major problems, or can I
>> commit these patches?
> Yes, please. Thanks.

Thanks, I also committed a testcase:

If you see any problems with the testcase please tell me.

Best regards,

More information about the llvm-commits mailing list