[llvm-commits] [llvm] r60915 - in /llvm/trunk/lib: CodeGen/SelectionDAG/DAGCombiner.cpp Target/X86/X86ISelLowering.cpp Target/X86/X86ISelLowering.h Target/X86/X86Instr64bit.td Target/X86/X86InstrInfo.td

[Bill Wendling]

On Fri, Dec 12, 2008 at 9:49 AM, Evan Cheng <evan.cheng at apple.com> wrote:
> Thanks. Just to clarify, the correct thing to do is to rename
> ADDOvf32rr to ADD32rr and delete the old ADD32rr. That is, we always
> select to an X86::ADD* instruction that produces two values, with the
> second one being EFLAGS. In the *normal* case, the scheduler will see
> EFLAGS is not used and it will mark it dead.
>
> But make sure you try it on a couple of these instructions first
> before you convert everything over. Just in case I am full of it. :-)
>
That sounds good. I went ahead and changed them. I wasn't able to get
unsigned multiply to work just yet, but will work on that next.

-bw