[llvm-commits] patch: extract element fix in DAGCombine

Dan Gohman gohman at apple.com
Tue Dec 9 17:07:04 PST 2008


Hi Mon Ping,

This patch looks good to me.

Dan

On Dec 9, 2008, at 1:35 AM, Mon Ping Wang wrote:

> Hi,
> This small patch fixes a small problem in DAGCombine for extract  
> vector element.  The current code will fail if we try to extract  
> from a bit convert of a shuffle where the bit convert changes the  
> number of elements.  The optimization tries to go through the bit  
> convert and uses the extract vector index to examine the mask of the  
> shuffle.  This is not safe when the bit convert changes the number  
> and size of the elements.  The fix is to only try to do the  
> optimization if the bit convert doesn't change the number of elements.
>
> -- Mon Ping
>
> <combine.patch>_______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits




More information about the llvm-commits mailing list