[llvm-commits] [llvm] r60344 - /llvm/trunk/lib/Transforms/Scalar/InstructionCombining.cpp

Bill Wendling isanbard at gmail.com
Mon Dec 1 21:09:09 PST 2008


On Dec 1, 2008, at 9:03 PM, Chris Lattner wrote:

> On Dec 1, 2008, at 12:32 AM, Bill Wendling wrote:
>
>> /// FoldOrWithConstants - This helper function folds:
>> ///
>> +///     ((A | B) & 1) | (B & -2)
>> ///
>> /// into:
>> ///
>> +///     (A & 1) | B
>> +///
>> +/// The constants aren't important. Only that they don't overlap.
>> (I.e., the XOR
>> +/// of the two constants is "all ones".)
>
> I don't think this comment is correct, "1" and "4" don't overlap, but
> they don't xor to -1.
>
Okay.

-bw




More information about the llvm-commits mailing list