[llvm-commits] [llvm-gcc-4.2] r60004 - /llvm-gcc-4.2/trunk/gcc/llvm-backend.cpp

[Devang Patel]

On Nov 25, 2008, at 10:43 AM, Chris Lattner wrote:

>
> On Nov 24, 2008, at 6:34 PM, Devang Patel wrote:
>
>> Author: dpatel
>> Date: Mon Nov 24 20:34:49 2008
>> New Revision: 60004
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=60004&view=rev
>> Log:
>>
>> Disable loop-index-split for now.
>> It has a bug that is encouraging me to rewrite large portion of this
>> pass.
>
> Should this also be disabled from opt?

I intend to fix loop-index-split today. If I can't make it then I'll  
disable it from opt before the end of the day.
Hey, the bug is a major oops and I'm kind of astonished that nightly  
testers did not catch it. But we should fix it soon.

int main() {
   int i;
   for (i =0; i < 6; ++i)
     if (i < 3)
       printf ("%d < 3\n", i);
     else
       printf ("%d >= 3\n", i);
     return 0;
}

prints

0 < 3
1 < 3
2 < 3
3 < 3
3 >= 3
4 >= 3
5 >= 3

-
Devang
>
>
> -Chris
>
>>
>>
>>
>> Modified:
>>   llvm-gcc-4.2/trunk/gcc/llvm-backend.cpp
>>
>> Modified: llvm-gcc-4.2/trunk/gcc/llvm-backend.cpp
>> URL: http://llvm.org/viewvc/llvm-project/llvm-gcc-4.2/trunk/gcc/llvm-backend.cpp?rev=60004&r1=60003&r2=60004&view=diff
>>
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> = 
>> =====================================================================
>> --- llvm-gcc-4.2/trunk/gcc/llvm-backend.cpp (original)
>> +++ llvm-gcc-4.2/trunk/gcc/llvm-backend.cpp Mon Nov 24 20:34:49 2008
>> @@ -444,7 +444,7 @@
>>    PM->add(createLoopRotatePass());            // Rotate Loop
>>    PM->add(createLICMPass());                  // Hoist loop
>> invariants
>>    PM->add(createLoopUnswitchPass(optimize_size ? true : false));
>> -    PM->add(createLoopIndexSplitPass());        // Split loop index
>> +    //  PM->add(createLoopIndexSplitPass());        // Split loop
>> index
>>    PM->add(createInstructionCombiningPass());
>>    PM->add(createIndVarSimplifyPass());        // Canonicalize
>> indvars
>>    PM->add(createLoopDeletionPass());          // Delete dead loops
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

-
Devang