[llvm-commits] [llvm-gcc-4.2] r59991 - in /llvm-gcc-4.2/trunk/gcc: config/darwin.h llvm-backend.cpp

[Devang Patel]

Bill,

One nit-pick

On Nov 24, 2008, at 3:21 PM, Bill Wendling wrote:

> =
> =
> =
> =
> =
> =
> =
> =
> ======================================================================
> --- llvm-gcc-4.2/trunk/gcc/llvm-backend.cpp (original)
> +++ llvm-gcc-4.2/trunk/gcc/llvm-backend.cpp Mon Nov 24 17:21:13 2008
> @@ -1133,6 +1133,11 @@
>     if (const char *Section =
>         LLVM_IMPLICIT_TARGET_GLOBAL_VAR_SECTION(decl)) {
>       GV->setSection(Section);
> +
> +#ifdef TARGET_ADJUST_CFSTRING_NAME
> +      if (!GV->hasName() && GV->hasInternalLinkage())

pl. move this check inside darwin.c TARGET_ADJUST_CFSTRING_NAME macro.
>
> +        TARGET_ADJUST_CFSTRING_NAME(GV, Section);
> +#endif
>     }
> #endif
>   }

Thanks!
-
Devang