[llvm-commits] [llvm] r58887 - /llvm/trunk/lib/Transforms/Utils/PromoteMemoryToRegister.cpp

[Devang Patel]

On Nov 16, 2008, at 9:58 AM, Chris Lattner wrote:

>
> On Nov 7, 2008, at 8:12 PM, Daniel Dunbar wrote:
>
>> Author: ddunbar
>> Date: Fri Nov  7 22:12:17 2008
>> New Revision: 58887
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=58887&view=rev
>> Log:
>> Rework r58829, allowing removal of dbg info intrinsics during alloca
>> promotion.
>> - Eliminate uses after free and simplify tests.
>
> Thanks Daniel and Devang.
>
> One request: this is now doing a whole extra pass over all of the  
> load/stores to an alloca just to check for debug info (in  
> RemoveDebugUses).  Could you make AnalyzeAlloca do the "removing of  
> debug intrinsic" logic instead?  This should restore the speed of  
> mem2reg at -O2/-O3 etc.


Done.
-
Devang