[llvm-commits] Patch: vector shuffle for generalized vector shuffle

[Duncan Sands]

Hi Mon Ping, I can't help feeling that rather than repeating almost
the same code twice, you could use a loop instead.  Then you can
"inline" DeterVectorShuffleUse, which as far as I can see can lead
to additional simplifications (it also seems to be written in a kind
of complicated way).  In fact, you can determine which lo/hi parts
to use on the fly as you work your way down the mask, building the
new mask vector as you go, rather than prescanning the mask, then
building the new mask vector afterwards.  Just some thoughts.

Ciao,

Duncan.