[llvm-commits] [llvm-gcc-4.2] r58633 - in /llvm-gcc-4.2/trunk/gcc: c-common.c stub-c.c tree.c

[Bill Wendling]

On Mon, Nov 3, 2008 at 12:35 PM, Dale Johannesen <dalej at apple.com> wrote:
>
> On Nov 3, 2008, at 11:44 AMPST, Bill Wendling wrote:
>
>> Author: void
>> Date: Mon Nov  3 13:44:35 2008
>> New Revision: 58633
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=58633&view=rev
>> Log:
>> * Move generic_block_literal_struct_type into the tree.c file. This
>> isn't ideal,
>>  but it's used there and in dwarf2out.c only. It's not ideal because
>> this is a
>>  C-family specific call.
>
> The "right" way to do this sort of thing in gcc is to use a langhook,
> which is null for languages that don't support the feature.
> (People tend to avoid doing this because it's a PITA, you have to
> modify 7 or 8 files IIRC.)  See the langhooks* files.  I suggest
> taking an existing langhook and grepping for it throughout to see how
> this works.
>
Okay. I'm going to talk with the person who created the original patch
and see if I can convince her to redo it.

-bw