[llvm-commits] [PATCH] catch user error in Pass.h

Török Edwin edwintorok at gmail.com
Fri Oct 31 10:28:33 PDT 2008


On 2008-10-31 19:23, Devang Patel wrote:
> On Oct 31, 2008, at 10:16 AM, Török Edwin wrote:
>
>   
>> Hi,
>>
>> The attached patch adds an assert to Pass.h to prevent mistakes like
>> this which successfully compiles&links:
>>
>> MyFunctionPass() : FunctionPass(ID) {}
>>
>> instead of
>>
>> MyFunctionPass() : FunctionPass(&ID) {}
>>
>>
>> OK to commit?
>>     
>
> ok. Watch out for 80 cols limit.
>   

Fixed the 80 col limit, and committed.

Thanks,
--Edwin




More information about the llvm-commits mailing list